python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

fix: update deprecated notificationConfig in healthcare api

Open noerog opened this issue 1 year ago • 1 comments

Description

Fixes b/310269530

Checklist

noerog avatar Sep 12 '24 01:09 noerog

File "/workspace/healthcare/api-client/v1/fhir/fhir_stores_test.py", line 244, in test_patch_fhir_store
    fhir_stores.patch_fhir_store(project_id, location, dataset_id, fhir_store_id)
TypeError: patch_fhir_store() missing 1 required positional argument: 'pubsub_topic'

Seems like the test needs to be updated.

davidcavazos avatar Sep 12 '24 23:09 davidcavazos

File "/workspace/healthcare/api-client/v1/fhir/fhir_stores_test.py", line 244, in test_patch_fhir_store
    fhir_stores.patch_fhir_store(project_id, location, dataset_id, fhir_store_id)
TypeError: patch_fhir_store() missing 1 required positional argument: 'pubsub_topic'

Seems like the test needs to be updated.

My mistake, the topic should be optional. Added a fix but 3.8 and 3.12 builds are still failing, though the test logs are empty. Will wait to see if they build.

noerog avatar Nov 13 '24 13:11 noerog