python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

fix(gae): resolve linting issues in main_test.py

Open iennae opened this issue 1 year ago • 3 comments

Description

unblocks merging of #12544

iennae avatar Sep 03 '24 21:09 iennae

Tests appear to be failing because there's no pytest defined for Python 3+

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/2d6db5de16f38e09a0bce9674bebf705a6c2a364/appengine/standard/iap/requirements-test.txt#L2

(this is a similar issue to what I am getting in another PR, will update with suggested resolution)

(why were these tests green earlier? they appear to be kokoro skipped last time this sample was run)

glasnt avatar Sep 04 '24 04:09 glasnt

thank you @glasnt ! I was wondering what was up

iennae avatar Sep 04 '24 21:09 iennae

This will be the sort of thing you'll need to update to:

https://github.com/GoogleCloudPlatform/python-docs-samples/pull/12561/files#diff-72885259355e2caa839d2ffcc71fad928d4af9bc5dae781a408a468f0068d885R3

glasnt avatar Sep 04 '24 22:09 glasnt

I reproduced this locally. I think six is not an indirect dependency anymore. I think we can simply add it to the dependencies.

davidcavazos avatar Oct 03 '24 20:10 davidcavazos