prometheus-engine icon indicating copy to clipboard operation
prometheus-engine copied to clipboard

feat: add config-reloader readiness

Open TheSpiritXIII opened this issue 1 year ago • 5 comments

This change adds a readiness endpoint to the config-reloader. This helps Kubernetes be more accurate in accessing that workloads are up.

The primary reason I added it is for https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1076 -- I wanted the config-reloader to start running before Prometheus is running. However, the config-reloader must hit a reload URL. As a "hack", I made it hit an endpoint of itself that does nothing. Since this endpoint is functionally the same as a readiness endpoint, I figured we might as well add a few more missing pieces to turn this into a readiness endpoint that Kubernetes can hit. This also helps make the PRs smaller and hopefully easier to review.

TheSpiritXIII avatar Jul 16 '24 19:07 TheSpiritXIII

Can you fill out the description and describe what this change is doing and the motivation for it?

pintohutch avatar Aug 02 '24 02:08 pintohutch

@pintohutch I updated the description. Feel free to push back on this change!

TheSpiritXIII avatar Aug 02 '24 14:08 TheSpiritXIII

@TheSpiritXIII - IIUC our discussion around supporting "empty" mandatory flag/config will make this change unnecessary. Is that your understanding as well?

pintohutch avatar Aug 05 '24 13:08 pintohutch

@pintohutch yes this change becomes non-critical. This PR may still provide a slightly better signal over when a workload is "ready" than we have today, but again, let's not prioritize it unless we need to.

TheSpiritXIII avatar Aug 05 '24 17:08 TheSpiritXIII

LGTM, but we need to resolve the conflicts. Thanks!

bwplotka avatar Sep 18 '24 08:09 bwplotka