php-docs-samples
php-docs-samples copied to clipboard
Pub/Sub: samples audit and cleanup
In addition to #1178, please also add:
pubsub_enable_subscription_ordering: docspubsub_list_topic_subscriptions: docs, this is different from listing project subscriptions.pubsub_publisher_concurrency_control: docs. This is optional, depending on if concurrency control even makes sense in PHP.pubsub_publisher_retry_settings: docspubsub_publish_custom_attributes: docspubsub_publish_with_error_handler: docs. The existing sample doesn't show how to handle publish failures. It's a quickstart publish sample.pubsub_publish_with_ordering_keys: docspubsub_resume_publish_with_ordering_keys: docs. There are two code includes in this section. Resume publish is towards the end of the section and shows theresume_publishmethod.pubsub_subscriber_async_pull: docs. Does this make sense in PHP?pubsub_subscriber_async_pull_custom_attributes: docs. Does this make sense in PHP?pubsub_subscriber_error_listener: docs. This is optional. The Java sample is the best example. Note that this method may not exist in PHP.pubsub_subscriber_flow_settings: docspubsub_subscriber_sync_pull_with_lease: docs
Remove:
- Remove the region tag
pubsub-publishbut keep the other region tagpubsub_quickstart_publisherand keep the sample.
The PR to fix this will probably be big. Feel free to break it into logical chunks.