php-docs-samples icon indicating copy to clipboard operation
php-docs-samples copied to clipboard

Add 2 tutorials for Symfony

Open Sethbass opened this issue 5 years ago • 3 comments

Hello @bshaffer ,

I have created these 2 new tutorials. Hope everything is fine :)

Sebastien

Sethbass avatar Mar 05 '20 14:03 Sethbass

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 05 '20 14:03 googlebot

@Sethbass To fix the issue with your email address, take the following steps from your master branch

# Add this repo (GoogleCloudPlatform/php-docs-samples) as a remote
git remote add google [email protected]:googlecloudplatform/php-docs-samples
git fetch google master
# Check out a NEW branch with your changes (you should always submit Pull Requests from a feature branch)
git checkout -b add-2-tutorials-to-symfony
# make your new branch up-to-date with the latest code from THIS repo
git rebase -Xtheirs b1a6f0a

Now you have a new branch add-2-tutorials-to-symfony that is up-to-date with the latest code from this branch. The next step is to squash all of your changes into a new commit so we can have everything under the same email. Do that by running the following commands:

# stage all the changes you've made 
git reset 36e3e93419e6849b28edb3f9285913fb211a8dc5~1
# Add your changes and commit them (we are consolidating all your changes into one new commit)
git add .
git ci -am "Adds 2 new tutorials to symfony"
# push your changes up to your repo
git push origin add-2-tutorials-to-symfony

FINALLY you can submit a NEW pull request with your changes and we can close this one.

Sound good?

bshaffer avatar Mar 11 '20 18:03 bshaffer

What would be even better is to move the changes you've made to README.md to GoogleCloudPlatform/community instead, as that will update the actual live tutorial. We are removing all the changes in README.md to instead point to the live tutorial, so there's only one source for this tutorial (see https://github.com/GoogleCloudPlatform/php-docs-samples/pull/1034)

bshaffer avatar Mar 11 '20 18:03 bshaffer