nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

feat: compute_snapshot_schedule_attach/list

Open gryczj opened this issue 11 months ago • 13 comments

Description

Fixes #<ISSUE-NUMBER>

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [x] Tests pass: npm test (see Testing)
  • [x] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [x] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [x] Please merge this PR for me once it is approved

gryczj avatar Dec 02 '24 15:12 gryczj

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Dec 02 '24 15:12 snippet-bot[bot]

Can you please try to fix the conflict @gryczj ?

kweinmeister avatar Dec 06 '24 20:12 kweinmeister

@BigBlackWolf PTAL

rsamborski avatar Dec 11 '24 11:12 rsamborski

Oh, I noticed that wrote a comment, but didn't submit 😅 Thanks, @rsamborski

Can you please try to fix the conflict @gryczj ?

Joanna is on vacations and I am going to support her with open PRs. @kweinmeister I've resolved the conflicts, do you have any other concerns?

BigBlackWolf avatar Dec 11 '24 12:12 BigBlackWolf

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

ghost avatar Dec 18 '24 23:12 ghost

@code-review-assist walkthrough

iennae avatar Dec 19 '24 04:12 iennae

@code-review-assist walkthrough

umairidris avatar Dec 19 '24 05:12 umairidris

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

ghost avatar Dec 19 '24 05:12 ghost

@code-review-assist walkthrough

umairidris avatar Dec 19 '24 05:12 umairidris

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

ghost avatar Dec 19 '24 05:12 ghost

@code-review-assist walkthrough

umairidris avatar Dec 20 '24 00:12 umairidris

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

ghost avatar Dec 20 '24 00:12 ghost

The users that are currently failing CLA had CLA signed at the time they were committing the changes. Please force-merge the PR.

m-strzelczyk avatar Jan 13 '25 13:01 m-strzelczyk