nodejs-docs-samples
nodejs-docs-samples copied to clipboard
feat: compute_snapshot_schedule_attach/list
Description
Fixes #<ISSUE-NUMBER>
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
- [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
- [x] Tests pass:
npm test(see Testing) - [x] Lint pass:
npm run lint(see Style) - [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
- [x] This pull request is from a branch created directly off of
GoogleCloudPlatform/nodejs-docs-samples. Not a fork. - [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
- [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
- [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
- [x] Please merge this PR for me once it is approved
Here is the summary of changes.
You are about to add 2 region tags.
- compute/snapshotSchedule/attachSnapshotSchedule.js:20, tag
compute_snapshot_schedule_attach - compute/snapshotSchedule/snapshotScheduleList.js:20, tag
compute_snapshot_schedule_list
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
Can you please try to fix the conflict @gryczj ?
@BigBlackWolf PTAL
Oh, I noticed that wrote a comment, but didn't submit 😅 Thanks, @rsamborski
Can you please try to fix the conflict @gryczj ?
Joanna is on vacations and I am going to support her with open PRs. @kweinmeister I've resolved the conflicts, do you have any other concerns?
Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.
@code-review-assist walkthrough
@code-review-assist walkthrough
Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.
@code-review-assist walkthrough
Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.
@code-review-assist walkthrough
Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.
The users that are currently failing CLA had CLA signed at the time they were committing the changes. Please force-merge the PR.