nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

feat: Adding API v2 Mute rule samples

Open rafaelMurata opened this issue 1 year ago • 4 comments

Description

b/349577531

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [ ] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [ ] Tests pass: npm test (see Testing)
  • [ ] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ ] Please merge this PR for me once it is approved

rafaelMurata avatar Jun 26 '24 14:06 rafaelMurata

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jun 26 '24 14:06 snippet-bot[bot]

Hi @rafaelMurata, thanks for submitting. I'm going to take a look at this and your other pending pull requests and get you updates within the next five days.

subfuzion avatar Jul 11 '24 03:07 subfuzion

Hi @rafaelMurata, this PR is failing for one of the same reasons as #3722 (missing GCLOUD_ORGANIZATION). Please apply the same guidance I gave there for resolving the issue.

subfuzion avatar Jul 18 '24 06:07 subfuzion