nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

feat: Adding API v2 IAM+Notifications samples

Open rafaelMurata opened this issue 1 year ago • 2 comments

Description

Fixes #<ISSUE-NUMBER>

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [ ] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [ ] Tests pass: npm test (see Testing)
  • [ ] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ ] Please merge this PR for me once it is approved

rafaelMurata avatar Jun 17 '24 12:06 rafaelMurata

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jun 17 '24 12:06 snippet-bot[bot]

@subfuzion Thanks for your help. Now I have an error in the tests because a pubsub topic called test_topic is missing; Can you kindly create this topic for me?

rafaelMurata avatar Jun 25 '24 14:06 rafaelMurata

@subfuzion Thanks for your help. Now I have an error in the tests because a pubsub topic called test_topic is missing; Can you kindly create this topic for me?

Hi @rafaelMurata, thanks for following up. I'm going to take a look at this and your other pull requests and get you updates within the next five days.

subfuzion avatar Jul 11 '24 03:07 subfuzion

@rafaelMurata Almost finished with updates that will let us merge your PR, but you need to sign the CLA, or unfortunately I'll have to close your pull requests unmerged.

subfuzion avatar Aug 12 '24 19:08 subfuzion