nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

chore(concepts/termination): split samples into directories

Open ace-n opened this issue 3 years ago • 2 comments

Example PR for b/230368998

Questions for reviewers:


If we want to switch from functions_ to cloudfunctions_ as a region-tag prefix, should I do that:

  1. in this PR?
  2. as part of a separate effort?

These samples aren't really practical to test. I assume, therefore, the lack of tests is OK?

ace-n avatar Aug 23 '22 03:08 ace-n

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Aug 23 '22 03:08 snippet-bot[bot]

separate effort as the functions -> cloudfunctions is a large sized effort and involves collaboration with TW

iennae avatar Aug 23 '22 20:08 iennae