java-docs-samples
java-docs-samples copied to clipboard
fix(compute): bug fixes HyperdisksIT test
Description
Fixes #<ISSUE-NUMBER>
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
- [x] I have followed Sample Format Guide
- [ ]
pom.xmlparent set to latestshared-configuration - [ ] Appropriate changes to README are included in PR
- [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
- [x] Tests pass:
mvn clean verifyrequired - [x] Lint passes:
mvn -P lint checkstyle:checkrequired - [ ] Static Analysis:
mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only - [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
- [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
- [ ] Please merge this PR for me once it is approved
Can you include description on the bugs this PR fixes. Also, why do we need three different test classes? Can all the tests be grouped inside the same class as it belongs to a logical group?
Having three tests in one class causes the PoolProvisionedIops value limit to be exceeded for one zone. Creating Hyperdisk Storage Pool with PoolProvisionedIops value less than 10000 cause error: "message": "Provisioned IOPS 3000 is not a multiple of 10000." Creating Hyperdisk Storage Pool with PoolProvisionedIops value more than 10000 cause error: "Operation with name "operation-..." failed with status = HttpJsonStatusCode{statusCode=PERMISSION_DENIED} and message = FORBIDDEN" Splitting these tests in separate file solved issue.
If same zone is the issue, would it be possible to declare different zones for each testcase, but within the same test file?