java-docs-samples icon indicating copy to clipboard operation
java-docs-samples copied to clipboard

Asset inventory: searchAllResources sample not working for Bigquery Dataset #8798

Open ssvir opened this issue 1 year ago • 2 comments

Description

Unignore SearchIT.testSearchAllResourcesExample cause problems with the dataset are fixed, and the test working

Fixes #8798

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [ ] I have followed Sample Format Guide
  • [ ] pom.xml parent set to latest shared-configuration
  • [ ] Appropriate changes to README are included in PR
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] Tests pass: mvn clean verify required
  • [ ] Lint passes: mvn -P lint checkstyle:check required
  • [ ] Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ ] Please merge this PR for me once it is approved

ssvir avatar Apr 22 '24 10:04 ssvir

@ssvir Could you please link the PR which fixed the issue with the dataset?

Sita04 avatar Apr 23 '24 03:04 Sita04

@ssvir Could you please link the PR which fixed the issue with the dataset?

Hey @Sita04 , I tried to find those changes, but it looks like we have no changes inside this test or inside SearchAllResourcesExample.searchAllResources, and I checked all issues inside #8798 and didn't find anything useful, either. I guess the main changes present inside BigQuery lib.

ssvir avatar Apr 23 '24 08:04 ssvir