java-docs-samples
java-docs-samples copied to clipboard
GoogleCloudPlatform
docs: add samples for using timeouts
Adds samples for running queries and updates with timeouts. This is one of the most frequently asked questions for the Spring Data Spanner project.
Here is the summary of changes.
You are about to add 2 region tags.
- spanner/spring-data/src/main/java/com/example/spanner/SpannerRepositoryTimeoutSample.java:19, tag
spanner_spring_data_repository_timeout_sample - spanner/spring-data/src/main/java/com/example/spanner/SpannerTemplateTimeoutSample.java:19, tag
spanner_spring_data_template_timeout_sample
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
![snippet-bot[bot] avatar](https://avatars.githubusercontent.com/in/62122?v=4 "Published by a pub.dev verified publisher"){kind=small}
We also expect tests for each sample
There are no tests or test infrastructure at all set up for this project, which makes adding tests for these samples difficult.
We also expect tests for each sample
There are no tests or test infrastructure at all set up for this project, which makes adding tests for these samples difficult.
It is a part of our policy for samples to have tests: https://googlecloudplatform.github.io/samples-style-guide/#testing. Without tests samples are not maintainable. The api-spanner-java team owns the spanner samples, therefore without explicit consent from this owner we may not be able to accept these samples.
api-spanner-java
Specifically the Spring Data Spanner project is maintained by a different team.
@meltsufin Could you chime in here, please? Do you know whether there's a specific reason that there are no tests set up for these samples? Or are there any plans for doing so?
api-spanner-java
Specifically the Spring Data Spanner project is maintained by a different team.
@meltsufin Could you chime in here, please? Do you know whether there's a specific reason that there are no tests set up for these samples? Or are there any plans for doing so?
We have tests for Spring Data Spanner samples the we maintain in spring-cloud-gcp. We do not maintain java-docs-samples repo, however.
@anguillanneuf Would you mind merging this PR? I don't think I have permission to merge anything in this repo.