java-docs-samples icon indicating copy to clipboard operation
java-docs-samples copied to clipboard

docs(compute-samples): added samples and tests for custom machine type

Open Sita04 opened this issue 3 years ago • 4 comments

Added Compute Machine type samples and tests. Docs: https://cloud.google.com/compute/docs/instances/creating-instance-with-custom-machine-type

Sita04 avatar May 24 '22 12:05 Sita04

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar May 24 '22 12:05 snippet-bot[bot]

Kindly provision these permissions: roles/compute.instanceAdmin.v1 and roles/compute.storageAdmin TIA!

Sita04 avatar May 24 '22 19:05 Sita04

@averikitsch can you review my comments? I think I still need someone reviewing my reviews

Shabirmean avatar Jun 01 '22 23:06 Shabirmean

Thanks @Shabirmean for the review. Addressed all your comments. The class structure was supposed to be in the format you suggested. Looks like the auto code linter had other plans :) Thanks for bringing it up!

Sita04 avatar Jul 29 '22 18:07 Sita04