golang-samples icon indicating copy to clipboard operation
golang-samples copied to clipboard

feat(vertexai): Multimodal sample with video

Open Deleplace opened this issue 1 year ago • 6 comments

Same code as the multimodal sample, but with the URL of a video.

Deleplace avatar Feb 12 '24 17:02 Deleplace

Yes. IMO it's fine to have code duplicated in the modules of each samples.

Factoring would imply putting image+video in the same sample folder, which is fine too.

Deleplace avatar Feb 12 '24 18:02 Deleplace

Yes. IMO it's fine to have code duplicated in the modules of each samples.

Factoring would imply putting image+video in the same sample folder, which is fine too.

I think maybe we can just show both video or image in the multimodal sample and link to it from both places? Having identical samples different with just the link may be confusing to users who will be looking for the difference and not finding any

eliben avatar Feb 12 '24 22:02 eliben

In this page we want to show a distinct snippet in the two section "Image" and "Video"

https://cloud.google.com/vertex-ai/docs/generative-ai/multimodal/send-multimodal-prompts#gemini-send-multimodal-samples-go

Deleplace avatar Feb 12 '24 23:02 Deleplace

In this page we want to show a distinct snippet in the two section "Image" and "Video"

https://cloud.google.com/vertex-ai/docs/generative-ai/multimodal/send-multimodal-prompts#gemini-send-multimodal-samples-go

OK, fair enough, then please make it as identical as possible, except perhaps a comment and the link itself. I think there are some extra differences like whitespace right now

eliben avatar Feb 13 '24 01:02 eliben

OK, fair enough, then please make it as identical as possible, except perhaps a comment and the link itself. I think there are some extra differences like whitespace right now

Done, they're now line-for-line identical. The difference is s/image/video/.

Deleplace avatar Feb 13 '24 17:02 Deleplace

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Feb 15 '24 23:02 snippet-bot[bot]