golang-samples icon indicating copy to clipboard operation
golang-samples copied to clipboard

feat(speech): Add speech StreamingRecognize samples

Open shubhamkr619 opened this issue 1 year ago • 7 comments

Description

Added support to stt v2 apis for livecaption and livecaption_from_file. Missing for a customer to follow with samples.

Fixes #3754 Required the support the stt_v2 apis

Feat # Add support for stt v2 apis

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [*] I have followed Contributing Guidelines from CONTRIBUTING.MD
  • [*] Tests pass: go test -v ./.. (see Testing)
  • [*] Code formatted: gofmt (see Formatting)
  • [*] Vetting pass: go vet (see Formatting)
  • [*] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [*] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [*] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [*] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [*] Please merge this PR for me once it is approved

shubhamkr619 avatar Jan 22 '24 14:01 shubhamkr619

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jan 22 '24 14:01 snippet-bot[bot]

These should be in the snippets/ folder, similar to the others: https://github.com/GoogleCloudPlatform/golang-samples/tree/main/speech/snippets

And can you make them analogous to the python samples? https://github.com/GoogleCloudPlatform/python-docs-samples/tree/196be7a900be64ed5429a17f07e28ac255e20642/speech/snippets

nitsanshai avatar Jan 22 '24 16:01 nitsanshai

Thanks Shubham and Kodanda for implementing on the ask and creating the PR. I am working with product team to merge the same.

hpkaur86 avatar Jan 22 '24 16:01 hpkaur86

@nitsanshai Thank you for the review. Working on it.

hpkaur86 avatar Jan 22 '24 16:01 hpkaur86

Sure, let me look into these changes tomorrow.

On Mon, Jan 22, 2024 at 10:22 PM hpkaur86 @.***> wrote:

@nitsanshai https://github.com/nitsanshai Thank you for the review. Working on it.

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/golang-samples/pull/3753#issuecomment-1904411274, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWBERBQNJJLLTVRBFF5BRDYP2KOTAVCNFSM6AAAAABCFJ4MCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGQYTCMRXGQ . You are receiving this because you authored the thread.Message ID: @.***>

--

Thanks & Regards, Shubham Cell: +91-7022-03-1114/ +91-9899-63-9828 Skype: annu.shubham

shubhamkr619 avatar Jan 22 '24 18:01 shubhamkr619

@nitsanshai , as per your suggestion code has been changed. Please review the same.

shubhamkr619 avatar Jan 23 '24 14:01 shubhamkr619

Can you change the PR name to: docs(samples): speech StreamingRecognize samples

nitsanshai avatar Jan 30 '24 14:01 nitsanshai

@muncus , please review this

shubhamkr619 avatar Mar 04 '24 06:03 shubhamkr619