functions-framework-java icon indicating copy to clipboard operation
functions-framework-java copied to clipboard

Added "hook" for server start event

Open wcarmon opened this issue 4 years ago • 4 comments
trafficstars

This allows tests to detect when server starts. Tests will execute faster than polling. Avoids exposing the server instance. Should have zero impact on existing usages

wcarmon avatar Dec 10 '20 18:12 wcarmon

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 10 '20 18:12 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 10 '20 18:12 google-cla[bot]

@googlebot I signed it!

wcarmon avatar Dec 10 '20 19:12 wcarmon

Sorry @wcarmon, features like this need to be discussed much further before a PR is sent.

Do you mind creating a GitHub issue first and discussing your requirements?

grant avatar Dec 11 '20 05:12 grant

Thanks for the PR! Since there hasn't been discussion about this for a few years I'm going to close it out for now.

It looks like this is related to a general-purpose lifecycle hooks proposal: https://github.com/GoogleCloudPlatform/functions-framework/issues/56 It's likely we'd want to approve that before taking any code for specific functions frameworks so we can ensure they all behave the same way.

josephlewis42 avatar May 22 '23 23:05 josephlewis42