cloud-opensource-java icon indicating copy to clipboard operation
cloud-opensource-java copied to clipboard

Glue

Open elharo opened this issue 6 years ago • 4 comments
trafficstars

Consider whether we should adopt any parts of https://glue-docs.appspot.com/ for jlbp.dev. E.g. font choices, max width.

elharo avatar Nov 13 '19 18:11 elharo

https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/1253 uses Glue

garrettjonesgoogle avatar Feb 29 '20 00:02 garrettjonesgoogle

Glue's CSS is available in CDN https://glue-docs.appspot.com/get-started/cdn/ If we use the CDN, we don't need to maintain the sass files in #1253 .

suztomo avatar Mar 04 '20 15:03 suztomo

The reason for the scss files in #1253 is to support extension, which is used for header tags. I have since removed the glue.scss file in #1253 , and accomplished the same effect using javascript. The PR used the CDN for glue from the beginning and still does.

garrettjonesgoogle avatar Mar 04 '20 23:03 garrettjonesgoogle

Thank you for clarification.

suztomo avatar Mar 05 '20 03:03 suztomo