cloud-build-notifiers icon indicating copy to clipboard operation
cloud-build-notifiers copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Fix color in Slack Notifier

Open henry0312 opened this issue 3 years ago • 4 comments

color should be passed into attachments array. https://api.slack.com/reference/messaging/attachments#fields

Example

Before fix

image

After fix

image

henry0312 avatar Jun 02 '22 12:06 henry0312

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 02 '22 12:06 google-cla[bot]

Maybe related: #139 ?

FWIW, we are seeing the same issue

wyardley avatar Aug 10 '22 03:08 wyardley

yeah, this PR will solve the same issue :) And I've been waiting for review and merge.

henry0312 avatar Aug 11 '22 01:08 henry0312

It would be pretty awesome if someone could merge this. FWIW, it looks good to me.

d47id avatar Aug 23 '22 19:08 d47id

/gcbrun

fayfaychan avatar Jan 23 '23 21:01 fayfaychan

Actually this is similar to https://github.com/GoogleCloudPlatform/cloud-build-notifiers/pull/139 which already got merge so i'll close this for now.

fayfaychan avatar Jan 23 '23 21:01 fayfaychan