preload-webpack-plugin icon indicating copy to clipboard operation
preload-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChromeLabs

Adding "searchByChunkId" option

Open michellocana opened this issue 6 years ago • 2 comments

As i commented in #91, the plugin currently checks only chunk.name when using include option, this pull request make possible to search by chunk id, so we can preload chunks named by webpack's NamedChunksPlugin

michellocana avatar Mar 19 '19 12:03 michellocana

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 19 '19 12:03 googlebot

@jeffposnick i signed the CLA for my github account, do i need to do something else

michellocana avatar May 28 '19 13:05 michellocana