houdini.how icon indicating copy to clipboard operation
houdini.how copied to clipboard

Add Tag Filter

Open Kartik1397 opened this issue 4 years ago • 9 comments

Fixes #10

Screenshot

Screenshot from 2021-01-24 02-19-57

Kartik1397 avatar Jan 23 '21 21:01 Kartik1397

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jan 23 '21 21:01 google-cla[bot]

@googlebot I signed it!

Kartik1397 avatar Jan 23 '21 21:01 Kartik1397

Hello @Kartik1397, thank you for your proposal 😊

I have a few suggestions:

Colors

  • The (x) button to remove the filter doesn't have a good contrast in dark mode theme
  • Is difficult for me to see the current tag selected
Screen Shot 2021-03-01 at 23 18 40

Accessibility

Can you add title to tags

User eXperience

Can you remove the # navigation? Really the user doesn't change the URL, and has a bad experience when he/she wants to back.

Screen Shot 2021-03-01 at 23 19 43

nucliweb avatar Mar 01 '21 22:03 nucliweb

Hi @Kartik1397! Did you have a chance to review @nucliweb's suggestions?

una avatar Mar 10 '21 17:03 una

Hi @una, Thanks for pointing this, it completely slipped my mind. Will try to do this as soon as possible.

Kartik1397 avatar Mar 10 '21 19:03 Kartik1397

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 10 '21 20:03 google-cla[bot]

Hi @nucliweb, Thank you for reviewing this PR. For me, everything seems good in dark mode. deploy-preview-150--keen-thompson-a26224 netlify app_resources_ (2) I have tested this on Ubuntu and macOS with chrome v89.0.4389.82

Kartik1397 avatar Mar 10 '21 20:03 Kartik1397

Hi @nucliweb, Thank you for reviewing this PR. For me, everything seems good in dark mode. deploy-preview-150--keen-thompson-a26224 netlify app_resources_ (2) I have tested this on Ubuntu and macOS with chrome v89.0.4389.82

macOS Big Sur in Dark mode

Screen Shot 2021-03-10 at 23 03 26

nucliweb avatar Mar 10 '21 22:03 nucliweb

@una Can you see the X in white color with Dark mode?

nucliweb avatar Mar 10 '21 22:03 nucliweb