bubblewrap icon indicating copy to clipboard operation
bubblewrap copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChromeLabs

Add support for Android 13 themed icons

Open NotWoods opened this issue 3 years ago • 12 comments

Android 13 introduces an API for Themed Icons, which are monochrome icons on a colored background. This change adds support to create those icons from a web app manifest.

Note that Android requires an Adaptive Icon for this to work. Consequently, you must have a maskable icon AND a monochrome icon.

Tested with https://monochrome.fyi/manifest.json

Screenshot of Android 13 homescreen with "Monochrome" PWA icon. All icons are themed, including the PWA.

NotWoods avatar Feb 11 '22 06:02 NotWoods

Code looks good to me. I wonder if we'd like to have this behind a feature flag, since Android 13 is still beta and APIs might change. @PEConn and @nohe427 for thoughts.

andreban avatar Feb 11 '22 21:02 andreban

Code looks good to me - I agree with Andre about putting this behind a flag until the Android 13 APIs are fixed.

PEConn avatar Feb 14 '22 09:02 PEConn

Hi @NotWoods and @andreban , two days ago we had the official release of Android 13 for Pixel devices.

https://developer.android.com/about/versions/13

Would be nice if this feature could be implemented so my apps will fit with the new themes icons.

Anyways thanks for your amazing work and making this possible!

Stevie-Ray avatar Aug 17 '22 11:08 Stevie-Ray

is it worth adding some description to the readme?

dartess avatar Dec 15 '22 06:12 dartess

hey all! love this PR. It would be awesome if this could be approved and merged now that Android 13 is no longer in beta :)

ashnohe avatar Dec 19 '22 20:12 ashnohe

@PEConn @andreban Is there anything left that prevents this pull request from merging?

FluorescentHallucinogen avatar Feb 03 '23 13:02 FluorescentHallucinogen

I haven't tested it since Android 13 came out of beta. If anyone has a chance to do it and let me know if it works, happy to merge.

andreban avatar Feb 03 '23 14:02 andreban

@andreban

If anyone has a chance to do it and let me know if it works, happy to merge.

Could you please rebase this PR and publish alpha npm package for this branch (like https://github.com/ardatan/graphql-tools/pull/2065#issuecomment-699501299) for easier testing by more people?

Is that exactly what the publish-canary script in package.json does? 🤔

FluorescentHallucinogen avatar Feb 20 '23 09:02 FluorescentHallucinogen

Yep, that's what publish-canary does.

andreban avatar Feb 20 '23 10:02 andreban