web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Patterns - patch for broken demo's that used `import`

Open argyleink opened this issue 3 years ago • 2 comments
trafficstars

Fixes CSP issues for remaining patterns

bundle and minify all scripts for no external deps

argyleink avatar Aug 10 '22 22:08 argyleink

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/patterns/components/split-buttons/index.md

  • This file passed all of our automated Markdown audits.

Deploy Preview for web-dev-staging ready!

Name Link
Latest commit 7e932d7e2f2eb47d3b78155de7509beea050928d
Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/62f436fa6fb8aa0008ae9600
Deploy Preview https://deploy-preview-8499--web-dev-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 22:08 netlify[bot]

can this get a review please so the demo's arent broken for visitors?

argyleink avatar Aug 11 '22 22:08 argyleink

@argyleink If not done already, you may want to check locally it works as intended. You can emulate PROD environment on your local machine that with the command line below:

ELEVENTY_ENV=prod npm --node-options '--max_old_space_size=8192' run dev

beaufortfrancois avatar Aug 12 '22 06:08 beaufortfrancois