web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

[Add Manifest article] Add `translations`

Open tomayac opened this issue 4 years ago • 7 comments
trafficstars

Changes proposed in this pull request:

  • Add translations

We're still awaiting the final design, this is mostly a placeholder PR until the design is final.

tomayac avatar Oct 25 '21 06:10 tomayac

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 138a038a31ddac7a3be7b5929402cfdc70817be1

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/617654de084e560007ce5ad1

😎 Browse the preview: https://deploy-preview-6520--web-dev-staging.netlify.app

netlify[bot] avatar Oct 25 '21 06:10 netlify[bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/progressive-web-apps/add-manifest/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 458

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/progressive-web-apps/add-manifest/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 458

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

stale[bot] avatar Jan 25 '22 05:01 stale[bot]

Still waiting for the spec.

tomayac avatar Jan 25 '22 13:01 tomayac

@tomayac is this still ongoing?

rachelandrew avatar Jul 12 '22 09:07 rachelandrew

It is, but we're still waiting for https://github.com/w3c/manifest/issues/676 to get closed.

tomayac avatar Jul 12 '22 09:07 tomayac

After being started in 2021, this feature still hasn't landed and is pending more discussion, so it's fair to close this PR. Please keep the branch around, so we can get back to the proposed changes if need be.

tomayac avatar Aug 16 '23 15:08 tomayac

@tomayac as you know we're migrating, so you'll need to take a copy of the content.

rachelandrew avatar Aug 16 '23 15:08 rachelandrew

Will the repos be deleted? I thought we'd archive them?!

tomayac avatar Aug 16 '23 15:08 tomayac

Not really sure what the plan is, I need to check what we are expected to do (I'm sure there is a process) but if it were me, and something was important to me to keep, I'd make sure I had a copy of it just in case.

rachelandrew avatar Aug 16 '23 15:08 rachelandrew

Understood. I'll dump the article contents in a doc then.

tomayac avatar Aug 16 '23 16:08 tomayac