lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Remove `devtoolsLogs` and `traces` compat artifacts

Open adamraine opened this issue 2 years ago • 4 comments

Carry-over from https://github.com/GoogleChrome/lighthouse/issues/15060 Initial pass: https://github.com/GoogleChrome/lighthouse/pull/15276

We are keeping these compat artifacts for 11.0 at least. We can potentially drop them in 12.0.

Non-breaking:

  • [ ] Remove all our usages of artifacts.devtoolsLogs and artifacts.traces
  • [x] ~Ensure downstream users (e.g. pubads) remove usages of artifacts.devtoolsLogs and artifacts.traces~
  • [x] Update docs to reference new artifacts

Breaking:

  • [x] Handle the error trace/dtlog differently
  • [ ] Remove defaultPass prefix from saved artifacts (i.e. defaultPass.trace.json -> trace.json)
  • [ ] Remove the compat artifacts devtools-log-compat and trace-compat

adamraine avatar Jul 25 '23 22:07 adamraine

FYI #15843

connorjclark avatar Feb 28 '24 23:02 connorjclark

Am I correct in assuming that "compat artifacts" refers to the old API (which was kept for compatibility reasons), and artifacts.DevtoolsLog && artifacts.Trace will remain in place?

benschwarz avatar Feb 28 '24 23:02 benschwarz

Am I correct in assuming that "compat artifacts" refers to the old API (which was kept for compatibility reasons), and artifacts.DevtoolsLog && artifacts.Trace will remain in place?

Yes

adamraine avatar Feb 28 '24 23:02 adamraine