lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

`s` or `sec` in report opportunities

Open adamraine opened this issue 3 years ago • 5 comments

Moving this discussion from https://github.com/GoogleChrome/lighthouse/pull/14329#issuecomment-1230846765.

I could go either way but maybe s makes more sense to be consistent with older versions of LH.

adamraine avatar Aug 31 '22 18:08 adamraine

+1 for s. sec totally throws me.

a plus side is that narrow means theres no whitespace between number and unit and so we should have to deal with wrapping issues less. :)

paulirish avatar Aug 31 '22 19:08 paulirish

IMO sec is weird. FWIW, APA recommends s, as does NIST.

Interestingly NIST specifically calls out sec as an unacceptable abbreviation because s is the internationally-recognized SI symbol for seconds (implying if we're going to use an abbreviation instead of the full "seconds" then maybe we shouldn't be localizing this at all).

brendankenny avatar Aug 31 '22 19:08 brendankenny

CLDR over here being slackers

paulirish avatar Aug 31 '22 19:08 paulirish

Of course, NIST is a branch of the US federal government, so we should maybe get other opinions before taking an american saying "no need to localize!" at face value :)

But for the original question, going with narrow seems like the best option.

brendankenny avatar Aug 31 '22 19:08 brendankenny

narrow SGTM. I did a quick test to see what narrow looked like for ms and it only removed the space.

Screen Shot 2022-08-31 at 1 55 06 PM

I'm thinking we keep ms as short

adamraine avatar Aug 31 '22 20:08 adamraine