developer.chrome.com icon indicating copy to clipboard operation
developer.chrome.com copied to clipboard

Add Fugu landing page

Open tomayac opened this issue 3 years ago • 2 comments

Changes proposed in this pull request:

  • Add Fugu landing page.

tomayac avatar Aug 05 '22 16:08 tomayac

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/blog/fugu-showcase/index.md

  • This file passed all of our automated Markdown audits.

site/en/blog/fugu-status/index.md

  • This file passed all of our automated Markdown audits.

site/en/blog/web-custom-formats-for-the-async-clipboard-api/index.md

  • This file passed all of our automated Markdown audits.

Deploy Preview for developer-chrome-com ready!

Name Link
Latest commit d82d11501bc6dbd0bd90bc918ae367407c589682
Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/632c8cfddba90d0008fc1775
Deploy Preview https://deploy-preview-3391--developer-chrome-com.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 05 '22 16:08 netlify[bot]

This is now ready for review.

tomayac avatar Sep 19 '22 13:09 tomayac

@rachelandrew, this is now ready for Tech Writer review. @petele has reviewed for content.

tomayac avatar Sep 21 '22 13:09 tomayac

@tomayac you have an additional resources box bottom right that is currently empty. This is looking nice though!

I'd really like to get the remaining content linked here moved off web.dev. I'm going to get Aaron to look at it as soon as he has a signed CLA to allow him to write to GitHub.

rachelandrew avatar Sep 22 '22 05:09 rachelandrew

[Y]ou have an additional resources box bottom right that is currently empty. This is looking nice though!

This looks right to me. It's the same as the Workbox one, just with two boxes instead of more. Or what do you mean?

Screenshot 2022-09-22 at 11 10 34

I'd really like to get the remaining content linked here moved off web.dev. I'm going to get Aaron to look at it as soon as he has a signed CLA to allow him to write to GitHub.

Nice, thanks. Looking forward to having everything on one site. Less clutter and confusion.

tomayac avatar Sep 22 '22 09:09 tomayac

I see, that's a heading, I added a comment. It needs to be first in the source, then there is CSS that moves it visually last. If you pick the block up in DevTools and move it first you'll see that working.

rachelandrew avatar Sep 22 '22 14:09 rachelandrew

@rachelandrew I think we're good now. I'll fix the Workbox page as well, see https://github.com/GoogleChrome/developer.chrome.com/pull/3799.

tomayac avatar Sep 23 '22 09:09 tomayac