developer.chrome.com icon indicating copy to clipboard operation
developer.chrome.com copied to clipboard

Update navigation API article

Open jakearchibald opened this issue 3 years ago • 3 comments

Preview: https://deploy-preview-3390--developer-chrome-com.netlify.app/docs/web-platform/navigation-api/

  • Updates the documentation and code examples for the switch from transitionWhile to intercept
  • Documents scroll handling
  • Documents focus handling
  • More detail on the types of navigations you do/don't want to intercept
  • Less focus on updateCurrentEntry

@domenic: mind reviewing?

@samthor: I don't think there's anything here you'd disagree with, but your name is still on this, so you might want to take a quick look.

jakearchibald avatar Aug 05 '22 16:08 jakearchibald

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/web-platform/navigation-api/index.md

  • This file passed all of our automated Markdown audits.

Deploy Preview for developer-chrome-com ready!

Name Link
Latest commit 7afc085cca9009a6f129e98bb26448c3d61072a3
Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/62fe0c36cd87d40009435f89
Deploy Preview https://deploy-preview-3390--developer-chrome-com.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 05 '22 16:08 netlify[bot]

@rachelandrew this is ready for review and landing. The CLA check is failing due to @domenic, but he's a Googler so I presume it's fine?

jakearchibald avatar Aug 09 '22 10:08 jakearchibald

Is there anything I need to do before this can be reviewed and merged?

jakearchibald avatar Aug 18 '22 08:08 jakearchibald

@jakearchibald no - I just missed the original message (feel free to ping me on Chat if I'm ignoring something). I'll take a look now.

rachelandrew avatar Aug 18 '22 08:08 rachelandrew

Rachel Andrew @.***> schrieb am Do., 18. Aug. 2022, 10:58:

@jakearchibald https://github.com/jakearchibald no - I just missed the original message (feel free to ping me on Chat if I'm ignoring something). I'll take a look now.

— Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/developer.chrome.com/pull/3390#issuecomment-1219216805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWFPIAFPDXHTOMDE3OQZVRTVZX3MTANCNFSM55WSATYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Miami87 avatar Aug 18 '22 09:08 Miami87

I just missed the original message (feel free to ping me on Chat if I'm ignoring something). I'll take a look now.

Shall do! Didn't want to hassle you. Also, should I be pinging you directly, or is there a group I can send this stuff to?

jakearchibald avatar Aug 18 '22 09:08 jakearchibald

You can always ask in the dc.c. chat if it's just something needing a random tech writer LGTM, but if you've directly assigned something to me and I'm ignoring it (or it's urgent) just prod me on chat.

rachelandrew avatar Aug 18 '22 10:08 rachelandrew