developer.chrome.com icon indicating copy to clipboard operation
developer.chrome.com copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChrome

Improve Getting Started article to fix some bugs and conventions #3353

Open aziz-shafique opened this issue 3 years ago • 3 comments

Fixes #3353 CLA Name: Abdul Aziz Shafique

Changes proposed in this pull request:

Fixes:

  • script popup.js should be executed inside window.onload, otherwise the extension throws a runtime exception for changeColor element null or undefined
  • script options.js should be executed inside window.onload, otherwise the extension throws a runtime exception for page element null or undefined

Improvements:

  • script files popup.js and options.js should be part of HTML <head> section
  • minor change to swap line 380 and 381, for code to look a bit more readable

aziz-shafique avatar Aug 02 '22 00:08 aziz-shafique

Deploy Preview for developer-chrome-com ready!

Name Link
Latest commit 7b56ba528aa3d39a2b749bfdc45477b7e1feb813
Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/62e86e5abe6efc0008e0d961
Deploy Preview https://deploy-preview-3354--developer-chrome-com.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 02 '22 00:08 netlify[bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/extensions/mv3/getstarted/index.md

  • This file passed all of our automated Markdown audits.

chrome-devrel-review-bot avatar Aug 02 '22 00:08 chrome-devrel-review-bot

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/extensions/mv3/getstarted/index.md

  • This file passed all of our automated Markdown audits.

chrome-devrel-review-bot avatar Aug 02 '22 00:08 chrome-devrel-review-bot

Closing this PR as there have been no additional changes since I shared feedback about a month ago.

dotproto avatar Sep 06 '22 22:09 dotproto