Goetz Lindenmaier

Results 76 comments of Goetz Lindenmaier

2luhenry Reviewi missing. Tests fail. Fix-request comment missing. Removing the tag. Why don't you fix this in head?

Hi @tkyc, please only label for approval if you have a review, i.e. the change is ready to be integrated. Did you make sure all relevant tests did run? Tier1...

Hi @varada1110 , I think you don't need the test adaptions to SimpleSSLContext. But the test will not work with jtreg 6.1 as it uses jupiter code not in jtreg...

https://github.com/openjdk/jdk11u-dev/pull/2553 solves a similar issue.

Hi @varada1110 please explain how you addressed the issues that came up in the 17u backport. Also explain how you tested to show the same issues don't surface in 11....

If we want to improve the memory size reporting in 11, I would propose to also backport [JDK-8299858](https://bugs.openjdk.org/browse/JDK-8299858) (and do this first).

Hi @Delawen, @tstuefe why do we need this in 17? Probably there is a follow up you want to backport?

Hi @tstuefe, I think there can be good reasons to backport NMT changes as they can improve analysing issues in 17. But there should always be a reason for each...

@tkiriyama, please first backport to 21. I remove the fix-request label in the meantime.