zig-win32 icon indicating copy to clipboard operation
zig-win32 copied to clipboard

Remove variadic args from the PROC callback types

Open jackwakefield opened this issue 4 years ago • 1 comments

These changes are copied from lean_and_mean.zig

The main reason for doing this is for i386 builds, where Zig defines std.os.windows.WINAPI as Stdcall rather than C, and Zig doesn't support variadic args unless the calling convention is C.

I completely appreciate there could be a reason I'm missing as to why these are variadic though!

jackwakefield avatar Mar 22 '21 21:03 jackwakefield

I completely appreciate there could be a reason I'm missing as to why these are variadic though!

More than likely you are overestimating the amount of manual code that's written here. On top of that it's likely that Zig itself generates other code nowadays for the same thing.

Have you tried these changes out in practice?

P.S. I'm very sorry about the late reply.

GoNZooo avatar Mar 24 '21 12:03 GoNZooo