RTM support?

[joeaudette]

wondering when glimpse will be available for aspnetcore RTM?

[Noeek]

up

[dazinator]

same - any news on a beta 2?

[avanderhoorn]

Sorry for the delay in response. We will hopefully have a build of Glimpse out that works on RC2 in the next few weeks. I'll keep this post updated as work progresses. Thanks for your patience!

[joeaudette]

RTM ships on June 27, so you might as well skip an rc2 version at this point unless it also will support RTM

[avanderhoorn]

Thats the plan.

[dazinator]

Thats the plan.

The problem is, lots of things changed between RC1 and RC2 projects - project.json schema changes, .xproj file changes, global.json file changes, not to mention package and code changes.

Microsoft have said that they will provide an automatic upgrade experience from RC2 based solutions to RTM. Not from RC1.

So I think this will still leave a lot of manual effort to upgrade. I personally have decided to update to RC2, so when RTM tooling ships I can take advantage of the automatic upgrade.

[avanderhoorn]

The current plan is to update the code to RC2 first, tag it and then start the work for RTM. Depending on the time it takes and if it makes sense, we will release the RC2 version before the RTM.

[dazinator]

Awesome. Feel free to try my RC1 to RC2 upgrade tool out if you like. https://github.com/dazinator/AspNetRC1toRC2UpgradeTool

[avanderhoorn]

Work on this officially starts on Monday. Hopefully wont take more than a week or two. Hard date for completion is the end of the month - there are other things happening which means the work can't go past that. So coming soon :D

[avanderhoorn]

If you haven't noticed work is starting to be checked in here https://github.com/Glimpse/Glimpse.Prototype/tree/avanderhoorn-rtm-update

[avanderhoorn]

Well its here. I've got a version of everything updated to be compatible with RTM. If people could try it out and give me feedback on whether everything works as expected, I can get things updated on nuget. Here is the current feed - https://www.myget.org/gallery/glimpseprototype.

[WolfspiritM]

Thanks! I tried using it by downloading the MusicStore sample and adding the feed to the nuget.config but it doesn't work correctly for me. I had to remove dotnet core and needed to compile for net451 cause netcoreapp1.0 gave me: Can not find compilation library location for package 'Glimpse.Agent.AspNet.Mvc' (might be something on my end?) For 451: It does compile without errors but when opening the site I just get the glimpse icon on the bottom right but no dashboard (I have to say I'm quiet new to glimpse so not sure if I'm doing everything 100% right):

Also when clicking on that icon I get this page: Chrome Javascript console shows twice:

• Uncaught TypeError: Cannot read property 'ok' of undefined message-repository-remote.js:49

Also I can't see any errors in the Output Window. Any idea?

[avanderhoorn]

Thats really weird... I just cloned down music store myself and it ran just fine.

My project.json look like:

  ...
  "dependencies": {
    "Glimpse.Agent.AspNet.Mvc": "2.0.0-beta2-201607261439",
    "Glimpse.Server": "2.0.0-beta2-201607261439",
    ...
  }
  ...

And my startup.cs looks like:

...
using Glimpse;

namespace MusicStore
{
    public class Startup
    {
        ...

        public void ConfigureServices(IServiceCollection services)
        {
            services.AddGlimpse();

            ...
        }

        public void ConfigureDevelopment(IApplicationBuilder app, ILoggerFactory loggerFactory)
        {
            app.UseGlimpse();

            ...
        }

        ...
    }
}

Are you able to confirm that your setup is similar?

[WolfspiritM]

I have the following as dependency but VS shows me that 2.0.0-beta2-201607261439 is the installed Reference so it should be fine.

    "Glimpse.Agent.AspNet.Mvc": "2.0.0-*",
    "Glimpse.Server": "2.0.0-*",

I can confirm that Startup.cs looks like that.

I now checked a bit what happens. It seems like the result from context is wrongly formatted for me. "$.getJson" is not returning and that makes the HUD completly not render. I then checked the result of: http://localhost:5000/glimpse/context/?contextId=dcc911aba2e540788469117426011cb1&types=environment%7Cuser-identification%7Cend-request%7Cbegin-request%7Cafter-action-invoked%7Cafter-action-view-invoked%7Cbefore-execute-command%7Cafter-execute-command%7Cafter-view-component

I have no idea why but it seems to return invalid JSON as payload:

...
{
    "id": "0233a1ec5c7c3f22a1e52540157799a2",
    "ordinal": 524,
    "types": ["after-action-invoked"],
    "payload": {
        "actionId": "2d93d149-adba-4fca-a038-4162a6b96558",
        "actionName": "Index",
        "actionControllerName": "Home",
        "actionInvokedEndTime": "2016-07-27T14:47:11.8773171Z",
        "actionInvokedDuration": 27,
        64,
        "actionInvokedOffset": 0,
        76
    },
    "context": {
        "id": "dcc911aba2e540788469117426011cb1",
        "type": "Request"
    }
}
...

I will try later today from another computer and see if it works there.

[avanderhoorn]

Ya thats really weird... let me know how you get on.

[WolfspiritM]

So after some debugging I think I figured out what the reason for the missing HUD is! I don't think it has anything to do with the move to RTM as I have never used Glimpse before and it seems like it just would never have worked. So I'm sorry to "spam" this issue with an unrelated problem. The Reason is that I'm running on a German System. That means ToString() will convert for example a float 1.2 to "1,2" not "1.2" as json expects it. The issue is in "Glimpse.Internal.TimeSpanConverter": https://github.com/Glimpse/Glimpse.Prototype/blob/dev/src/Glimpse.Common/Internal/Serialization/TimeSpanConverter.cs#L18 Right after changing that line to:

writer.WriteRawValue(result.ToString(CultureInfo.InvariantCulture));

Magicly the HUD appears!

There is however still an issue on both of my computers when running with dotnet core AND using the nuget package:

System.InvalidOperationException: Can not find compilation library location for package 'Glimpse.Agent.AspNet.Mvc'

To reproduce this I moved a freshly cloned "MusicStore" to another location outside of the Glimpse src directory (otherwise it will pick up the local files) and added a NuGet.config:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="Glimpse" value="https://www.myget.org/F/glimpseprototype/api/v3/index.json"/>
    <add key="NuGet" value="https://api.nuget.org/v3/index.json" />
  </packageSources>
</configuration>

Then after restore and run it will (at least for me) end up with the error above. This issue seems to be also tracked in: dotnet/cli#3781

[KoalaBear84]

This could be the problem as I never got the previous version working on MVC5, Dutch over here. But I do have as much as possible set to English.

I will check the new version out soon.

[WolfspiritM]

@KoalaBear84 I also have that most things to english but somehow this is set differently. What helped as a workaround to get the nuget package working (for net451) is: Region & language settings -> Additional date, time, & regional settings -> Under Region: Change date, time, or number formats -> Formats tab: "Additional settings..." ->Switching the Decimal symbol from "," to "." Didn't require any reboot or login/logoff. Only the App needed to be restarted of course.

[KoalaBear84]

Thanks, it looks like the format was still in Dutch. Will work much better in English indeed.

[avanderhoorn]

WOW!!! Great pickup guys and thanks so much for tracking that down. I would never have guessed that. I'll make the fix and get an update onto the feed hopefully in the next 24hrs or so. Will let everyone know when it goes up. My thinking is that this shouldn't effect people using english based systems.

[CaptainCow95]

FYI, it looks like you still need to update the main .nuspec file with netstandard entries. It fails to install on a .Net Core application unless you add an import for dnxcore50. The individual packages install fine, it is just the main Glimpse package that doesn't seem to install correctly.

[avanderhoorn]

@CaptainCow95 good catch, I'll update it as part of the next drop.

[KLuuKer]

Since miniprofiler has no build for .net core, I would love to see glimpse supporting the rtm build

[karldodd]

Any updates?

[alaatm]

Is this still alive? Last commit about 2 months ago!

[nikmd23]

We're still alive! We've got a lot of stuff happening in the background. We're going to address the feedback from @CaptainCow95 soon, and we'll make sure to update this thread when that fix is released.

We really appreciate your interest and support in our efforts. As you know, Glimpse v2, like ASP.NET, is a complete re-write, and we're taking the time to reconsider each and every feature. If you have any specific feedback or input you'd like to share, feel free to email me ([email protected]) and we can set up a call.

[alandillon]

I am in need of a new drop that has nuspec targeting .NETCoreApp1.0, any timeframe on at least that?

[joeaudette]

asp.net 1.1 is out, can't we at least get a preview release of glimpse on the standard nuget feed?

[Jetski5822]

Whats the word chaps, want to plug this in to Orchard 2 and would love an updated nuget package targeting 1.1.0-* if possible.

[avanderhoorn]

ok... just committed an update to get everything working with the final RTW bits (1.0.). This should also work for 1.1. but I haven't done any explicit testing on that yet. Within the next day or two, I hope to get a updated package published so that we can test those bits before pushing a wider update.