GitbookIO
Add hubspot integration
Add a new integration for HubSpot Reporting & Analytics. Roughly following hotjar integration implementation. Since there's no standard for where the HS JS is stored across regions and portals, I have set the entire URL from which the integration fetches the script as the configuration variable.
🦋 Changeset detected
Latest commit: 13a762c2cf14110334a471388364626e67ce5483
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @gitbook/integration-hubspot | Major |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for starting this PR @nimrod-codota and contributing to our Integration Platform! I'll be helping to look into getting this working with you.
Can you reach out to me over email (addison @ gitbook.com)? I just have a few more questions, but so far it's looking good to me!
+1 on this one. Would love to test it if needed @addisonschultz
You can provide me access to it like on the Mouseflow integration
hi @addisonschultz, saw your email on some necessary changes here. Will you be able to merge this after I enact the requested changes?
Hey @nimast - going to close this PR as I’ve got a new one up based off the work you’ve done that has been updated a little more. Thank you so much for you contribution!
https://github.com/GitbookIO/integrations/pull/533/files
If you’d like to make any edits, you can make edits on the branch linked above.
I would like my code to be added with my name on it. I think my contributions were already significant enough.
Apologies @nimast - I’d like to merge in your original contributions to the updated branch. Apologies for the mis-interpretation, there were some added changes we’d have liked to be included with the original PR, which I should have made on top of this branch.
thank you @addisonschultz! I appreciate it. I changed the base of this PR to your branch and merged it in so we don't have conflicts. Seems there are no outstanding changes except taking the commits from here. Please let me know if there's anything else I can do to support getting this merged. Thanks again!
Thanks again - and apologies for the miscommunication / direction! We’d like to make just a few more tweaks to it before we put it live. But thank you for your contribution, it’s greatly appreciated!