Client icon indicating copy to clipboard operation
Client copied to clipboard

MergeRequests::all: send datetimes with millisecond precision

Open janedbal opened this issue 1 year ago • 5 comments

We are iteratively fetching new MRs via:

updated_after=2023-01-24T18:05:25.801Z
&sort=asc
&order_by=updated_at

And there is more than 100 MR updated within a second. Current implementation causes the same MRs to be analysed again every time. But the API seems to support microsecond precision, so this should fix it.

janedbal avatar Dec 14 '23 11:12 janedbal

Adjusted the formatting:

  • 2023-01-24T18:05:25.801Z works
  • 2023-01-24T18:05:25.801+00:00 does not work

janedbal avatar Dec 14 '23 14:12 janedbal

This uses millisecond precision, not microsecond?

GrahamCampbell avatar Dec 14 '23 15:12 GrahamCampbell

Yes, adjusted title. GitLab API returns datetimes with milliseconds, not micro. So that is probably the best precision we can use.

janedbal avatar Dec 14 '23 15:12 janedbal

@GrahamCampbell any needed changes here?

janedbal avatar Dec 20 '23 08:12 janedbal

ping

janedbal avatar Jan 15 '24 11:01 janedbal

Thanks.

GrahamCampbell avatar Mar 17 '24 21:03 GrahamCampbell