py-gitguardian icon indicating copy to clipboard operation
py-gitguardian copied to clipboard

chore(sca): change SCAIgnoreVulnerability docstring to add new type of accepted identifier

Open gg-jonathangriffe opened this issue 1 year ago • 1 comments

This PR adds a new field cve_id to SCAIgnoredVulnerability to allow alternatively ignoring a vulnerability by cve_id and not identifier.

gg-jonathangriffe avatar Apr 25 '24 09:04 gg-jonathangriffe

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.38%. Comparing base (82f30b9) to head (766503f). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +0.01%     
==========================================
  Files           6        6              
  Lines         695      696       +1     
==========================================
+ Hits          642      643       +1     
  Misses         53       53              
Flag Coverage Δ
unittests 92.38% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 25 '24 09:04 codecov-commenter

I think we can close that one. Do you agree @gg-jonathangriffe?

agateau-gg avatar Jun 24 '24 07:06 agateau-gg