Support icon indicating copy to clipboard operation
Support copied to clipboard

[Feature Request] GPG support

Open infiniityr opened this issue 5 years ago • 5 comments

Hi,

It would be great to support the code signature with GPG. Actually it returns an error. image

Otherwise It is a really great app !

infiniityr avatar Mar 10 '20 15:03 infiniityr

Hello back,

For more information, I had my passphrase in the Keychain (I'm on MAC) and it still doesn't work. I don't have any issues with command lines.

infiniityr avatar Mar 10 '20 15:03 infiniityr

Hi @infiniityr. Thanks for bringing this up. It's interesting in that it looks like it can't find gpg. I'll look into this when I find some time.

GitFiend avatar Mar 11 '20 09:03 GitFiend

Even it's working (in my linux case) could we have a badge or anything else for alert for wrong/good check signature?

aurelhann avatar Jun 10 '20 05:06 aurelhann

@GitFiend @infiniityr

I just stumbled onto the same problem (GitFiend Version 0.30.1). It seems that for some reason GitFiend doesn't start with the proper environment on Mac?

As a work-around it's possible to launch GitFiend through the terminal using open -a GitFiend this will ofc pass your environment variables to GitFiend and then it works as expected.

I checked both bash and zsh and both know where gpg is. I installed gnupg and gnupg2 through brew and two important paths seem to be:

/usr/local/bin/gpg
/usr/local/MacGPG2/bin/gpg2

I could imagine GitFiend not seeing gpg2 with a custom folder inbetween, but gpg should be in good ol' /usr/local/bin so that should be perfectly visible to GitFiend 🤔 anyway, hope this helps.

Hazarth avatar Jan 12 '22 14:01 Hazarth

Thanks for valuable info @Hazarth. It seems macOS only provides "/usr/bin:/bin:/usr/sbin:/sbin" for PATH when the app starts (unless started from command line). I may be able to manually add /usr/local/bin if that would help.

@aurelhann That's a good idea. GPG signing is not currently part of my workflow and not used where I work and so this hasn't been top of my list. I do hope to start improving authentication workflows soon.

GitFiend avatar Jan 15 '22 01:01 GitFiend