Support icon indicating copy to clipboard operation
Support copied to clipboard

Enter to confirm dialogs

Open aaaidan opened this issue 5 years ago • 2 comments

Simple confirm and prompt dialogs can be dismissed with Esc but Enter key does nothing. I think it would be great if Enter confirmed the dialog.

E.g.

  • Delete branch confirm
  • Create branch/tag here dialog
  • Discard stash

aaaidan avatar Nov 18 '19 04:11 aaaidan

Thanks. I've been putting this off, nice to have an entry for it.

GitFiend avatar Nov 19 '19 00:11 GitFiend

Just giving GitFiend a try now and noticed this exact issue when discarding line changes. There's actually a bug with it now. (latest version, just downloaded it, Linux version 0.23.1, installed from Debian package)

when I click Discard, a confirmation dialog pops up, however when I hit Enter, yet another confirmation dialog pops up on top of the first one, I can hit enter as many times as I want, and they will stack on top of each other (I also need to dismiss them one by one).

To be honest, when I clicked discard I wasn't even expecting a dialog to open up, I was expecting the line to just disappear. The thing is in my case, I had several changes under each other, and to discard some of them I have to click discard, move the mouse and hit the OK button, then move back and discard another one. It's kinda slow like that so I'd personally like the option to discard with one click or movement.

That being said, I'm really looking forward learning and using GitFiend, first impressions are top notch so far!

Hazarth avatar Jun 10 '20 21:06 Hazarth