giskard icon indicating copy to clipboard operation
giskard copied to clipboard

GSK-3609 Avoid redundant questions in data generation

Open JiaenLiu opened this issue 1 year ago • 3 comments

Description

One fix to avoid the duplicated question generation in RAGET by assigning non-duplicated seed documents for each question generator during the question generation.

Related Issue

Type of Change

  • [ ] 📚 Examples / docs / tutorials / dependencies update
  • [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
  • [x] 🥂 Improvement (non-breaking change which improves an existing feature)
  • [ ] 🚀 New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🔐 Security fix

Checklist

  • [x] I've read the CODE_OF_CONDUCT.md document.
  • [x] I've read the CONTRIBUTING.md guide.
  • [x] I've written tests for all new methods and classes that I created.
  • [x] I've written the docstring in Google format for all the methods and classes that I used.
  • [ ] I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been modified)

JiaenLiu avatar Jul 24 '24 09:07 JiaenLiu

CI still failing, try adding the lockfile label to regenerate the pdm.lock

rabah-khalek avatar Aug 14 '24 14:08 rabah-khalek

QAing!

mattbit avatar Oct 31 '24 09:10 mattbit