DuckDB.NET Implementation of the Connection.GetSchema of the DataSourceInformation collection

Implementation of the Connection.GetSchema of the DataSourceInformation collection

Open magneto-81 opened this issue 1 year ago • 6 comments

May 20 '24 10:05 magneto-81

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.73%. Comparing base (292bc55) to head (028df4d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    88.38%   88.73%   +0.35%     
===========================================
  Files           54       54              
  Lines         1756     1802      +46     
  Branches       239      239              
===========================================
+ Hits          1552     1599      +47     
+ Misses         146      145       -1     
  Partials        58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

May 20 '24 10:05 codecov-commenter

Pull Request Test Coverage Report for Build 9157409247

Details

46 of 46 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 90.42%

Totals
Change from base Build 9156112100:	0.2%
Covered Lines:	1657
Relevant Lines:	1802

💛 - Coveralls

May 20 '24 10:05 coveralls

Is it possible to test it some other way? I.E what uses connection.GetSchema("DataSourceInformation")?

May 21 '24 20:05 Giorgi

Connection.GetSchema("DataSourceInformation") is used by generic software which, through the ado.net providers, allows its use. The information returned by this primitive is used to generate statements in a generic way (see for example DbMetaDataColumnNames.ParameterMarkerPattern).

May 28 '24 12:05 magneto-81

Can you add a test that uses those APIs (that call Connection.GetSchema("DataSourceInformation")) under the hood to validate that it generates correct statements? That would increase the confidence of this change a lot.

May 28 '24 12:05 Giorgi