stream-chat-swift icon indicating copy to clipboard operation
stream-chat-swift copied to clipboard

Swift 6: complete concurrency checking (LLC and UIKit)

Open laevandus opened this issue 7 months ago โ€ข 5 comments

[!IMPORTANT] StreamChatUI changes are in #3660 and will be merged to here. This PR can be reviewed already.

๐Ÿ”— Issue Links

Resolves IOS-735

๐ŸŽฏ Goal

  • Set Swift version to 6 and implement complete concurrency checking

๐Ÿ“ Summary

  • Sendable conformance to types
  • @Sendable to completion handlers
  • Many thread-safety related changes to @unchecked Sendable types (internal classes have manual handling and found many which did not guard that state properly)
  • Fixes warnings in the demo app (adding @Sendable to completion handlers creates warnings at callsites)
  • Backported AllocatedUnfairLock which is needed for static concurrency safe properties (our Atomic property wrapper can't be used)

๐Ÿ›  Implementation

๐Ÿงช Manual Testing Notes

Manual regression testing round when UIKit changes are merged into this branch.

โ˜‘๏ธ Contributor Checklist

  • [x] I have signed the Stream CLA (required)
  • [x] This change should be manually QAed
  • [ ] Changelog is updated with client-facing changes
  • [ ] Changelog is updated with new localization keys
  • [x] New code is covered by unit tests
  • [ ] Documentation has been updated in the docs-content repo

laevandus avatar May 05 '25 12:05 laevandus

1 Warning
:warning: Big PR
1 Message
:book: There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by :no_entry_sign: Danger

github-actions[bot] avatar May 05 '25 12:05 github-actions[bot]

SDK Size

title develop branch diff status
StreamChat 7.2 MB 7.28 MB +81 KB ๐ŸŸข
StreamChatUI 4.72 MB 4.73 MB +17 KB ๐ŸŸข

Stream-SDK-Bot avatar May 05 '25 12:05 Stream-SDK-Bot

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 10.85 ms -8.5% ๐Ÿ”ฝ ๐ŸŸก
Duration 2.6 s 2.54 s 2.31% ๐Ÿ”ผ ๐ŸŸข
Hitch time ratio 4 ms per s 4.28 ms per s -7.0% ๐Ÿ”ฝ ๐ŸŸก
Frame rate 75 fps 78.23 fps 4.31% ๐Ÿ”ผ ๐ŸŸข
Number of hitches 1 1.0 0.0% ๐ŸŸฐ ๐ŸŸข

Stream-SDK-Bot avatar May 05 '25 12:05 Stream-SDK-Bot

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

โœจ Finishing Touches
  • [ ] ๐Ÿ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share
๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 29 '25 11:05 coderabbitai[bot]

I am going to make breaking changes what we discussed separately, take all the feedback from this PR, and later create a brand new PR.

laevandus avatar Jul 30 '25 06:07 laevandus