Swift 6: complete concurrency checking (LLC and UIKit)
[!IMPORTANT] StreamChatUI changes are in #3660 and will be merged to here. This PR can be reviewed already.
๐ Issue Links
Resolves IOS-735
๐ฏ Goal
- Set Swift version to 6 and implement complete concurrency checking
๐ Summary
Sendableconformance to types@Sendableto completion handlers- Many thread-safety related changes to
@unchecked Sendabletypes (internal classes have manual handling and found many which did not guard that state properly) - Fixes warnings in the demo app (adding
@Sendableto completion handlers creates warnings at callsites) - Backported AllocatedUnfairLock which is needed for static concurrency safe properties (our Atomic property wrapper can't be used)
๐ Implementation
๐งช Manual Testing Notes
Manual regression testing round when UIKit changes are merged into this branch.
โ๏ธ Contributor Checklist
- [x] I have signed the Stream CLA (required)
- [x] This change should be manually QAed
- [ ] Changelog is updated with client-facing changes
- [ ] Changelog is updated with new localization keys
- [x] New code is covered by unit tests
- [ ] Documentation has been updated in the
docs-contentrepo
| 1 Warning | |
|---|---|
| :warning: | Big PR |
| 1 Message | |
|---|---|
| :book: | There seems to be app changes but CHANGELOG wasn't modified. Please include an entry if the PR includes user-facing changes. You can find it at CHANGELOG.md. |
Generated by :no_entry_sign: Danger
SDK Size
title |
develop |
branch |
diff |
status |
|---|---|---|---|---|
| StreamChat | 7.2 MB | 7.28 MB | +81 KB | ๐ข |
| StreamChatUI | 4.72 MB | 4.73 MB | +17 KB | ๐ข |
SDK Performance
target |
metric |
benchmark |
branch |
performance |
status |
|---|---|---|---|---|---|
| MessageList | Hitches total duration | 10 ms | 10.85 ms | -8.5% ๐ฝ | ๐ก |
| Duration | 2.6 s | 2.54 s | 2.31% ๐ผ | ๐ข | |
| Hitch time ratio | 4 ms per s | 4.28 ms per s | -7.0% ๐ฝ | ๐ก | |
| Frame rate | 75 fps | 78.23 fps | 4.31% ๐ผ | ๐ข | |
| Number of hitches | 1 | 1.0 | 0.0% ๐ฐ | ๐ข |
[!IMPORTANT]
Review skipped
More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.
193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.
You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
โจ Finishing Touches
- [ ] ๐ Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
๐ชง Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Quality Gate passed
Issues
67 New issues
0 Accepted issues
Measures
0 Security Hotspots
87.3% Coverage on New Code
0.0% Duplication on New Code
I am going to make breaking changes what we discussed separately, take all the feedback from this PR, and later create a brand new PR.