stream-chat-swift icon indicating copy to clipboard operation
stream-chat-swift copied to clipboard

[Swift6 migration] Added optional casting to some CoreData DTOs

Open martinmitrevski opened this issue 1 year ago โ€ข 1 comments

๐Ÿ”— Issue Links

Helps with https://stream-io.atlassian.net/browse/PBE-4993?atlOrigin=eyJpIjoiMDI5NDFhMTIxNDRiNDJlNDhkOTQxY2RkYWFjZDQ5NjgiLCJwIjoiaiJ9.

๐ŸŽฏ Goal

Fix errors in Swift 6 where explicit casting is needed for some CoreData DTOs.

Screenshot 2024-07-16 at 16 10 59

๐Ÿ“ Summary

Provide bullet points with the most important changes in the codebase.

๐Ÿ›  Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

๐ŸŽจ Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

๐Ÿงช Manual Testing Notes

Explain how this change can be tested manually, if applicable.

โ˜‘๏ธ Contributor Checklist

  • [ ] I have signed the Stream CLA (required)
  • [ ] This change should be manually QAed
  • [ ] Changelog is updated with client-facing changes
  • [ ] Changelog is updated with new localization keys
  • [ ] New code is covered by unit tests
  • [ ] Comparison screenshots added for visual changes
  • [ ] Affected documentation updated (docusaurus, tutorial, CMS)

๐ŸŽ Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

martinmitrevski avatar Jul 16 '24 14:07 martinmitrevski

1 Message
:book: Skipping Danger since the Pull Request is classed as Draft/Work In Progress

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Jul 16 '24 14:07 github-actions[bot]

CLosing this one for now.

nuno-vieira avatar Nov 11 '24 17:11 nuno-vieira