stream-chat-swift icon indicating copy to clipboard operation
stream-chat-swift copied to clipboard

Extra space before first list item in ordered list

Open alexandersandberg opened this issue 3 years ago • 3 comments

What did you do?

We recently upgraded from 4.15.0 to 4.18.0 and noticed that the first item in an ordered list now has some extra space.

I'm guessing this bug was introduced when markdown support was added in 4.17.0.

What did you expect to happen?

No extra space in the first list item.

What happened instead?

Extra space.

4.15.0 4.18.0
Before After

GetStream Environment

GetStream Chat version: 4.18.0 GetStream Chat frameworks: StreamChat, StreamChatUI iOS version: 15.4 Swift version: 5.6 Xcode version: 13.3 Device: iPhone 12 mini

Additional context

alexandersandberg avatar Jul 15 '22 15:07 alexandersandberg

Hi @alexandersandberg!

Thank you for the bug report! I was able to reproduce it as well.

We will track it internally and fix it as soon as possible 👍

Keep in mind, that if you are not interested in Markdown Support, you can always disable it like this: Appearance.default.formatters.isMarkdownEnabled = false, this will unblock you for now until we fix this. If of course, you are fine with disabling Markdown.

Best, Nuno

nuno-vieira avatar Jul 15 '22 16:07 nuno-vieira

Thanks, @nuno-vieira! We've been waiting for markdown support, so we will live with this bug for now. But thanks for the tip! 🙂

alexandersandberg avatar Jul 15 '22 17:07 alexandersandberg

Seems like with markdown enabled the bug here is the opposite of how it's stated in the title: aligned indents and hanging indents are desired in formatted lists, so the markdown is working correctly on the first item but not on the subsequent items.

Is there any progress on a fix in that direction?

gsbernstein avatar Nov 21 '23 19:11 gsbernstein

Hello @alexandersandberg, we have released a new iOS SDK version 4.51.0 which addresses issues with markdown. Thank you for reporting this issue.

laevandus avatar Mar 26 '24 14:03 laevandus