stream-chat-react-native icon indicating copy to clipboard operation
stream-chat-react-native copied to clipboard

Fix: Enable tap function on parent message of Thread

Open atsss opened this issue 2 years ago โ€ข 1 comments

๐ŸŽฏ Goal

  • The parent message is enabled to execute press functions in a thread

๐Ÿ›  Implementation details

  • Currently, users can't execute press functions on the parent messages in a thread.
    • Can't open URL inside of parent messages in a thread
    • Can't add any reactions to parent messages in a thread
    • Can't quote parent messages in a thread
  • Aimed for the same specs as Slack

https://github.com/GetStream/stream-chat-react-native/assets/17227480/d28f3f20-7a5f-41df-a926-f219d41d923c

๐ŸŽจ UI Changes

iOS

Before

https://github.com/GetStream/stream-chat-react-native/assets/17227480/bd1b0897-dd3c-4a59-8425-2881a8b5c919

After

https://github.com/GetStream/stream-chat-react-native/assets/17227480/0d336129-5896-44f7-a8c4-758a7a488803

Android

Before

https://github.com/GetStream/stream-chat-react-native/assets/17227480/d7a1637c-f40b-4500-b411-ce58194c574e

After

https://github.com/GetStream/stream-chat-react-native/assets/17227480/240b39b3-6efc-41d3-ab5e-a84c384a532e

๐Ÿงช Testing

โ˜‘๏ธ Checklist

  • [x] I have signed the Stream CLA (required)
  • [x] PR targets the develop branch
  • [x] Documentation is updated
  • [x] New code is tested in main example apps, including all possible scenarios
    • [x] SampleApp iOS and Android
    • [x] Expo iOS and Android

atsss avatar Oct 10 '23 02:10 atsss

Hey @atsss, we can only allow normal press here and with your solution the long press is also enabled for the thread message. Can you look forward to targeting the normal press event somehow? Thanks ๐Ÿ˜„

khushal87 avatar Feb 29 '24 08:02 khushal87

Closing it as it has been stale for a long time.

khushal87 avatar Jun 14 '24 07:06 khushal87