stream-chat-react-native icon indicating copy to clipboard operation
stream-chat-react-native copied to clipboard

fix: unresponsive clear button when the file type is not supported

Open khushal87 opened this issue 3 years ago โ€ข 1 comments

๐ŸŽฏ Goal

Fixes #1732

๐Ÿ›  Implementation details

The overlay is removed which was not making the entire file area unresponsive. It doesn't make sense to keep it and therefore it is removed in this PR.

๐ŸŽจ UI Changes

iOS
Before After
Android
Before After

๐Ÿงช Testing

โ˜‘๏ธ Checklist

  • [x] I have signed the Stream CLA (required)
  • [x] PR targets the develop branch
  • [ ] Documentation is updated
  • [x] New code is tested in main example apps, including all possible scenarios
    • [x] SampleApp iOS and Android
    • [x] Expo iOS and Android

khushal87 avatar Sep 30 '22 16:09 khushal87

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 30 '22 16:09 sonarqubecloud[bot]

:tada: This PR is included in version 5.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vishalnarkhede avatar Oct 10 '22 13:10 vishalnarkhede