stream-chat-react-native icon indicating copy to clipboard operation
stream-chat-react-native copied to clipboard

Published 20 hours ago • verified publisher icon GetStream

feat: make react-native-share and react-native-haptic-feedback optional

Open madsroskar opened this issue 3 years ago • 1 comments

** Draft for now, gotta write docs tommake it ready **

🎯 Goal

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • [ ] I have signed the Stream CLA (required)
  • [ ] PR targets the develop branch
  • [ ] Documentation is updated
  • [ ] New code is tested in main example apps, including all possible scenarios
    • [ ] SampleApp iOS and Android
    • [ ] Expo iOS and Android

madsroskar avatar Sep 29 '22 16:09 madsroskar

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 04 '22 08:10 sonarqubecloud[bot]

Nice job @madsroskar :)

vishalnarkhede avatar Oct 05 '22 09:10 vishalnarkhede

:tada: This PR is included in version 5.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vishalnarkhede avatar Oct 10 '22 13:10 vishalnarkhede