stream-chat-react-native icon indicating copy to clipboard operation
stream-chat-react-native copied to clipboard

Missing translation for 'Pinned by (user)'

Open findawayer opened this issue 3 years ago • 2 comments

Describe the bug Pinned by {{ user }} text that appears around a pinned message does not get translated.

Dev environment info (please complete/provide the following information):

  • Package version (stream-chat-react-native/stream-chat-expo): stream-chat-react-native
  • react-native or expo version: react-native v0.67.3
  • Device/Emulator (android/ios) and OS version:
  • Android Emulator: 31.2.10-8420304 (HAXM 7.6.5)
  • Android version: 11.0 (R) - API 30
  • Host machine: Windows 10 Pro

The same happens for any other environments in my use (e.g. iOS emulator or real devices).

To Reproduce Steps to reproduce the behavior:

  1. Change i18n config to anything else than English.
  2. Pin any message.
  3. Pinned by {{ user }} is still in English.

Expected behavior Please add Pinned by {{ user }} to the available translation message list.

Additional context It looks like MessagePinnedHeader component does not pass this message to the translation module.

  • https://github.com/GetStream/stream-chat-react-native/blob/develop/package/src/components/Message/MessageSimple/MessagePinnedHeader.tsx#L58

Screenshots image

findawayer avatar May 16 '22 04:05 findawayer

Hey, this is a valid issue. We will pick this up soon. Thank you. 😄

khushal87 avatar Jun 03 '22 07:06 khushal87

Hey team! Please add your planning poker estimate with ZenHub @Enigma-I-am @khushal87 @madsroskar @santhoshvai @vishalnarkhede

vanGalilea avatar Jun 07 '22 08:06 vanGalilea