scatter-js icon indicating copy to clipboard operation
scatter-js copied to clipboard

Typescript library

Open hossainiir opened this issue 7 years ago • 10 comments

Hi, I want to know is there any plan for typescript? Thanks

hossainiir avatar Oct 14 '18 15:10 hossainiir

Not at the moment, but a typings file can be provided in the future. I will leave this ticket open to remind me.

nsjames avatar Oct 14 '18 17:10 nsjames

@nsjames thanks, also typings would be great !!

hossainiir avatar Oct 14 '18 17:10 hossainiir

+1

grigio avatar Mar 20 '19 09:03 grigio

Out of necessity for a project at work, I've created the TS module declarations for the following packages:

  • @scatterjs/core
  • @scatterjs/eosjs2
  • @scatterjs/lynx

Would it be OK to make a PR to add them?

matei-radu avatar Sep 03 '19 07:09 matei-radu

yup go for it <3

nsjames avatar Oct 11 '19 03:10 nsjames

Out of necessity for a project at work, I've created the TS module declarations for the following packages:

  • @scatterjs/core
  • @scatterjs/eosjs2
  • @scatterjs/lynx

Would it be OK to make a PR to add them?

I am new to typescript and I don't known how to write the TS module declarations. May I have a copy of it?Thank you very much.

AnyPang avatar Oct 14 '19 09:10 AnyPang

@AnyPang I will make a PR to integrate the declarations into this repo this weekend. Then you can either

  • wait for the PR to be merged and a new release made, or
  • copy the declarations from the PR and add them manually to your project(s)

Unfortunately, I'm quite busy with work during the week so I cannot do this sooner.

matei-radu avatar Oct 14 '19 09:10 matei-radu

@matei-radu I can't find the TS declarations in the recent commits.Have you finished to make the PR?

AnyPang avatar Oct 23 '19 03:10 AnyPang

@AnyPang unfortunately, I've been busier than expected so I haven't finished yet. I will @ you on the PR once I open it

matei-radu avatar Oct 23 '19 05:10 matei-radu

@matei-radu OK.Thanks a lot.

AnyPang avatar Oct 23 '19 06:10 AnyPang