firefly icon indicating copy to clipboard operation
firefly copied to clipboard

Separate or relabel HeapBin and ProcBin proptests in lumen_runtime

Open KronicDeth opened this issue 6 years ago • 0 comments

The strategies for heap binaries pre-date the ProcBin implementation, so they generate byte sequences that can be > 64 bytes, the cut-off for ProcBin and so the "heap binary" tests are actually testing HeapBin and ProcBin.

One of two things should happen:

  • Separate out the strategies and have separate tests for heap and process binaries to isolate bugs to the HeapBin and ProcBin
  • Rename the heap binary strategies and tests to be "aligned binary" tests to match the AlignedBinary trait used for HeapBin and ProcBin.

KronicDeth avatar Aug 09 '19 13:08 KronicDeth