gerev icon indicating copy to clipboard operation
gerev copied to clipboard

Cross-platform support for getting a home directory path

Open suminb opened this issue 2 years ago • 3 comments

Although GerevAI is most likely going to be running on a Linux environment, it would still be nice to be able to run it on other environments such as macOS or Windows for development and/or testing purposes. This can be achieved by simply replacing /home/{os.getlogin() with Path.home(). I've noticed pathlib.Path is already in use, so we might as well use it to get the home directory path for the current user.

suminb avatar Mar 28 '23 12:03 suminb

Have you tested that locally + inside a docker?

Roey7 avatar Mar 30 '23 22:03 Roey7

@suminb , hi have you tested this? could you screenshot a working example.

yuvalsteuer avatar Apr 10 '23 12:04 yuvalsteuer

I haven't tested this inside a Docker. I'll show a screenshot when I test it.

suminb avatar Apr 12 '23 04:04 suminb