volesti
volesti copied to clipboard
Counting linear extensions using gaussian hmc
We have incorporated necessary changes to apply gaussian hmc to count linear extensions. Specifically, we have made the following changes:
Added a new option to use gaussian hmc in the executable file.
Previously the algorithm was unable to compute large volumes; now we are using long double instead of double to fix that.
Changed the scope of a crucial structure random variable to fix a bug.
There were some hardcoded templates, that assumed specific random walk. We have made necessary modifications to support any type of walk.
We have incorporated necessary changes to apply gaussian hmc to count linear extensions. Specifically, we have made the following changes:
Added a new option to use gaussian hmc in the executable file.
You mean the linear extensions example right? This is fine, thanks.
Previously the algorithm was unable to compute large volumes; now we are using long double instead of double to fix that.
This is using long double in linear extensions example, great!
Changed the scope of a crucial structure random variable to fix a bug.
What was the bug about? This is about the global variable that you create? If this is the case then please do not use global variables.
There were some hardcoded templates, that assumed specific random walk. We have made necessary modifications to support any type of walk.
I am not sure I understand this. You mean the default values of the template parameter of the random walk? Why what that a problem?
Codecov Report
Merging #230 (20be02c) into develop (38f6b34) will increase coverage by
0.30%. The diff coverage is100.00%.
@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
+ Coverage 53.78% 54.08% +0.30%
===========================================
Files 93 93
Lines 5552 5556 +4
Branches 2573 2575 +2
===========================================
+ Hits 2986 3005 +19
+ Misses 1029 1015 -14
+ Partials 1537 1536 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ks/gaussian_hamiltonian_monte_carlo_exact_walk.hpp | 78.46% <100.00%> (+23.62%) |
:arrow_up: |
| include/volume/volume_cooling_gaussians.hpp | 71.89% <100.00%> (+0.37%) |
:arrow_up: |
| include/random_walks/compute_diameter.hpp | 33.33% <0.00%> (-1.22%) |
:arrow_down: |
| include/preprocess/crhmc/crhmc_problem.h | 44.11% <0.00%> (-0.30%) |
:arrow_down: |
| include/convex_bodies/hpolytope.h | 80.21% <0.00%> (+0.73%) |
:arrow_up: |
Closing this as inactive.