volesti icon indicating copy to clipboard operation
volesti copied to clipboard

Inefficient handling of burn in phase in sampling functions

Open TolisChal opened this issue 4 years ago • 12 comments
trafficstars

In header include/sampling.hpp the sampling functions do not handle the burn in phase efficiently. They store the points of burn in phase and then they delete them.

RandomPointGenerator::apply(P, p, c, a, eta, nburns, walk_len, randPoints, push_back_policy, rng); randPoints.clear();

We need a new function to perform the burn in phase efficiently.

TolisChal avatar Oct 01 '21 12:10 TolisChal

I would like to work on this issue

purna135 avatar Jan 28 '22 15:01 purna135

I'd like to work on this issue if it's still open!

Rajat1206 avatar Feb 26 '22 14:02 Rajat1206

@TolisChal Is this still open? I would love to work on it

nanu1605 avatar Mar 01 '23 14:03 nanu1605

@nanu1605 please feel free to open a PR.

vissarion avatar Mar 03 '23 15:03 vissarion

@TolisChal Is this still open? I would love to work on it Hey, are you working with this issue, if not then please assign me this issue. I would love to work on it.

hzratali avatar Mar 13 '23 11:03 hzratali

@ha-rahman there are no assignments on issues, everyone is free to start working on a issue. The first pull request that is reviewed and approved will be merged.

vissarion avatar Mar 13 '23 11:03 vissarion

Thank you.

On Mon, 13 Mar 2023, 17:01 Vissarion Fisikopoulos, @.***> wrote:

@ha-rahman https://github.com/ha-rahman there are no assignments on issues, everyone is free to start working on a issue. The first pull request that is reviewed and approved will be merged.

— Reply to this email directly, view it on GitHub https://github.com/GeomScale/volesti/issues/180#issuecomment-1465976975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVNJLFOFDEEWDL32YF66GQLW34AS5ANCNFSM5FEROUGQ . You are receiving this because you were mentioned.Message ID: @.***>

hzratali avatar Mar 13 '23 11:03 hzratali

hey , can i work on this?

KhushV25 avatar Jul 12 '23 18:07 KhushV25

@KhushV25 sure, please go ahead and submit a PR.

vissarion avatar Jul 12 '23 20:07 vissarion

can i submit a PR?

nick2432 avatar Dec 17 '23 01:12 nick2432